Conversation
thomhurst
added
dependencies
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review: chore(deps): update tunit to 1.22.3
This is a straightforward Renovate-generated dependency bump PR updating all TUnit-family packages from 1.22.0 → 1.22.3 across 6 files.
Summary of Changes
Directory.Packages.props— Central package management updated for 6 TUnit packages (TUnit, TUnit.Assertions, TUnit.Assertions.FSharp, TUnit.AspNetCore, TUnit.Core, TUnit.Engine)TUnit.Templates/— Template project files updated for TUnit, TUnit.Assertions.FSharp, and TUnit.Playwright packages
Assessment
No issues found. The change is mechanically correct:
- All 7 TUnit-family packages are consistently bumped to the same
1.22.3patch version — no version skew between related packages. - The
Directory.Packages.propscentral version management approach is respected — the template.csproj/.fsprojfiles that have hardcoded versions (outside CPM) are also updated correctly. v1.22.3is a known-good release, with a single fix: "pass assembly version properties to dotnet pack" (#5274) — a safe patch to pull in.- No snapshot tests, source generator output, or public APIs are touched, so no
.verified.txtregeneration is needed.
One Observation (Non-blocking)
The template files under TUnit.Templates/content/ still carry hardcoded version strings rather than referencing a variable or the central Directory.Packages.props. This means each dependency bump requires updating both places. This is likely intentional (templates ship as standalone projects), but it's worth noting that a $(TUnitVersion) MSBuild property set at the repo level could simplify future bumps. Not a concern for this PR.
✅ Safe to merge.
There was a problem hiding this comment.
Code Review: chore(deps): update tunit to 1.22.3
This is a straightforward Renovate-generated dependency bump PR updating all TUnit-family packages from 1.22.0 → 1.22.3 across 6 files.
Summary of Changes
Directory.Packages.props— Central package management updated for 6 TUnit packages (TUnit, TUnit.Assertions, TUnit.Assertions.FSharp, TUnit.AspNetCore, TUnit.Core, TUnit.Engine)TUnit.Templates/— Template project files updated for TUnit, TUnit.Assertions.FSharp, and TUnit.Playwright packages
Assessment
No issues found. The change is mechanically correct:
- All 7 TUnit-family packages are consistently bumped to the same
1.22.3patch version — no version skew between related packages. - The
Directory.Packages.propscentral version management approach is respected — the template.csproj/.fsprojfiles that have hardcoded versions (outside CPM) are also updated correctly. v1.22.3is a known-good release, with a single fix: "pass assembly version properties to dotnet pack" (#5274) — a safe patch to pull in.- No snapshot tests, source generator output, or public APIs are touched, so no
.verified.txtregeneration is needed.
One Observation (Non-blocking)
The template files under TUnit.Templates/content/ still carry hardcoded version strings rather than referencing a variable or the central Directory.Packages.props. This means each dependency bump requires updating both places. This is likely intentional (templates ship as standalone projects), but it's worth noting that a $(TUnitVersion) MSBuild property set at the repo level could simplify future bumps. Not a concern for this PR.
✅ Safe to merge.
2 participants
This PR contains the following updates:
1.22.0→1.22.31.22.0→1.22.31.22.0→1.22.31.22.0→1.22.31.22.0→1.22.31.22.0→1.22.31.22.0→1.22.3Release Notes
thomhurst/TUnit (TUnit)
v1.22.3: 1.22.3What's Changed
Other Changes
Dependencies
Full Changelog: v1.22.0...v1.22.3
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.